Remove 'New' Badge from Extensions page (#19637)

It's no longer "new".

Author: carlos-zamora

src/cascadia/TerminalSettingsEditor/Extensions.cpp

@@ -37,7 +37,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         auto vmImpl = get_self<ExtensionsViewModel>(_ViewModel);
         vmImpl->ExtensionPackageIdentifierTemplateSelector(_extensionPackageIdentifierTemplateSelector);
         vmImpl->LazyLoadExtensions();
-        vmImpl->MarkAsVisited();
 
         if (vmImpl->IsExtensionView())
         {
@@ -363,11 +362,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         return _ExtensionPackageIdentifierTemplateSelector.SelectTemplate(CurrentExtensionPackage());
     }
 
-    bool ExtensionsViewModel::DisplayBadge() const noexcept
-    {
-        return !Model::ApplicationState::SharedInstance().BadgeDismissed(L"page.extensions");
-    }
-
     // Returns true if the extension is enabled, false otherwise
     bool ExtensionsViewModel::GetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings)
     {
@@ -436,12 +430,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         NavigateToColorSchemeRequested.raise(*this, nullptr);
     }
 
-    void ExtensionsViewModel::MarkAsVisited()
-    {
-        Model::ApplicationState::SharedInstance().DismissBadge(L"page.extensions");
-        _NotifyChanges(L"DisplayBadge");
-    }
-
     bool ExtensionPackageViewModel::SortAscending(const Editor::ExtensionPackageViewModel& lhs, const Editor::ExtensionPackageViewModel& rhs)
     {
         auto getKey = [&](const Editor::ExtensionPackageViewModel& pkgVM) {

src/cascadia/TerminalSettingsEditor/Extensions.h

@@ -46,7 +46,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         bool NoProfilesModified() const noexcept { return _profilesModifiedView.Size() == 0; }
         bool NoProfilesAdded() const noexcept { return _profilesAddedView.Size() == 0; }
         bool NoSchemesAdded() const noexcept { return _colorSchemesAddedView.Size() == 0; }
-        bool DisplayBadge() const noexcept;
 
         // Views
         Windows::Foundation::Collections::IObservableVector<Editor::ExtensionPackageViewModel> ExtensionPackages() const noexcept { return _extensionPackages; }
@@ -59,7 +58,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         void UpdateSettings(const Model::CascadiaSettings& settings, const Editor::ColorSchemesPageViewModel& colorSchemesPageVM);
         void NavigateToProfile(const guid profileGuid);
         void NavigateToColorScheme(const Editor::ColorSchemeViewModel& schemeVM);
-        void MarkAsVisited();
 
         static bool GetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings);
         static void SetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings, bool enableExt);

src/cascadia/TerminalSettingsEditor/Extensions.idl

@@ -23,7 +23,6 @@ namespace Microsoft.Terminal.Settings.Editor
         Boolean NoProfilesModified { get; };
         Boolean NoProfilesAdded { get; };
         Boolean NoSchemesAdded { get; };
-        Boolean DisplayBadge { get; };
 
         // Views
         IVector<ExtensionPackageViewModel> ExtensionPackages { get; };

src/cascadia/TerminalSettingsEditor/MainPage.xaml

@@ -167,10 +167,6 @@
                 <muxc:NavigationViewItem.Icon>
                     <FontIcon Glyph="&#xEA86;" />
                 </muxc:NavigationViewItem.Icon>
-                <muxc:NavigationViewItem.InfoBadge>
-                    <muxc:InfoBadge Style="{StaticResource NewInfoBadge}"
-                                    Visibility="{x:Bind ExtensionsVM.DisplayBadge, Mode=OneWay}" />
-                </muxc:NavigationViewItem.InfoBadge>
             </muxc:NavigationViewItem>
 
             <muxc:NavigationViewItemHeader x:Uid="Nav_Profiles" />