[Event Request] codeunit 5968 "Serv. Sales Tax Calculate"

[Kelly-cn]

Why do you need this change?

Can you add OnBeforeAddServiceLine, OnAfterAddServiceLine, OnAddServiceLineOnAfterTempSalesTaxAmountLineSetFilters and OnAddServiceLineOnAfterSetSalesTaxAmountLineFilter events to the AddServcieLine procedure just like codeunit 398 "Sales Tax Calculate" AddSalesLine procedure ?

Describe the request

We needs to add extra filter to the Sales Tax Amount Line before it insert or modify.

 procedure AddServiceLine(ServiceLine: Record "Service Line")
    var
        TaxArea: Record "Tax Area";
        TaxAreaLine: Record "Tax Area Line";
        TaxJurisdiction: Record "Tax Jurisdiction";
    begin
        OnBeforeAddServiceLine(ServiceLine);
        if not ServHeaderRead then begin
            ServiceHeader.Get(ServiceLine."Document Type", ServiceLine."Document No.");
            ServHeaderRead := true;
 ......
       TempSalesTaxAmountLine.SetRange("Tax Group Code", ServiceLine."Tax Group Code");
        TaxAreaLine.SetCurrentKey("Tax Area", "Calculation Order");
        TaxAreaLine.SetRange("Tax Area", ServiceLine."Tax Area Code");

       OnAddServiceLineOnAfterTempSalesTaxAmountLineSetFilters(TempSalesTaxAmountLine);

        if TaxAreaLine.FindSet() then
            repeat
                TempSalesTaxAmountLine.SetRange("Tax Jurisdiction Code", TaxAreaLine."Tax Jurisdiction Code");
                TempSalesTaxAmountLine."Tax Jurisdiction Code" := TaxAreaLine."Tax Jurisdiction Code";

                OnAddServiceLineOnAfterSetSalesTaxAmountLineFilter (TempSalesTaxAmountLine, ServiceLine, TaxAreaLine);

                if not TempSalesTaxAmountLine.FindFirst() then begin
 ......
             until TaxAreaLine.Next() = 0;
        SalesTaxCalculate.SetSalesTaxAmountLineTable(TempSalesTaxAmountLine);
        OnAfterAddServiceLine(TempSalesTaxAmountLine, ServiceLine)
    end;

[IntegrationEvent(false, false)]
    local procedure OnBeforeAddServiceLine(var ServiceLine: Record "Service Line");
    begin
    end;

[IntegrationEvent(false, false)]
    local procedure OnAddServiceLineOnAfterTempSalesTaxAmountLineSetFilters(var TempSalesTaxAmountLine: Record "Sales Tax Amount Line" temporary)
    begin
    end;

[IntegrationEvent(false, false)]
    local procedure OnAddServiceLineOnAfterSetSalesTaxAmountLineFilter(var TempSalesTaxAmountLine: Record "Sales Tax Amount Line" temporary; ServiceLine: Record "Service Line"; TaxAreaLine: Record "Tax Area Line");
    begin
    end;

[IntegrationEvent(false, false)]
    local procedure OnAfterAddServiceLine(TempSalesTaxLine: Record "Sales Tax Amount Line" temporary; ServiceLine: Record "Service Line")
    begin
    end;

Internal work item: AB#615906

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Summary: Add 4 new events to AddServiceLine procedure, matching the pattern from codeunit 398 "Sales Tax Calculate".

---

Implementation:

Event Call Sites (in AddServiceLine procedure):

    procedure AddServiceLine(ServiceLine: Record "Service Line")
    var
        TaxArea: Record "Tax Area";
        TaxAreaLine: Record "Tax Area Line";
        TaxJurisdiction: Record "Tax Jurisdiction";
    begin
        OnBeforeAddServiceLine(ServiceLine);
        if not ServHeaderRead then begin
            ...
        end;
        ...
        TempSalesTaxAmountLine.SetRange("Tax Group Code", ServiceLine."Tax Group Code");
        OnAddServiceLineOnAfterTempSalesTaxAmountLineSetFilters(TempSalesTaxAmountLine);
        TaxAreaLine.SetCurrentKey("Tax Area", "Calculation Order");
        TaxAreaLine.SetRange("Tax Area", ServiceLine."Tax Area Code");
        if TaxAreaLine.FindSet() then
            repeat
                TempSalesTaxAmountLine.SetRange("Tax Jurisdiction Code", TaxAreaLine."Tax Jurisdiction Code");
                TempSalesTaxAmountLine."Tax Jurisdiction Code" := TaxAreaLine."Tax Jurisdiction Code";
                OnAddServiceLineOnAfterSetSalesTaxAmountLineFilter(TempSalesTaxAmountLine, ServiceLine, TaxAreaLine);
                if not TempSalesTaxAmountLine.FindFirst() then begin
                    ...
                end;
            until TaxAreaLine.Next() = 0;
        SalesTaxCalculate.SetSalesTaxAmountLineTable(TempSalesTaxAmountLine);
        OnAfterAddServiceLine(TempSalesTaxAmountLine, ServiceLine);
    end;

Event Publishers (add at end of codeunit):

    [IntegrationEvent(false, false)]
    local procedure OnBeforeAddServiceLine(var ServiceLine: Record "Service Line")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAddServiceLineOnAfterTempSalesTaxAmountLineSetFilters(var TempSalesTaxAmountLine: Record "Sales Tax Amount Line" temporary)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAddServiceLineOnAfterSetSalesTaxAmountLineFilter(var TempSalesTaxAmountLine: Record "Sales Tax Amount Line" temporary; ServiceLine: Record "Service Line"; TaxAreaLine: Record "Tax Area Line")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterAddServiceLine(var TempSalesTaxAmountLine: Record "Sales Tax Amount Line" temporary; ServiceLine: Record "Service Line")
    begin
    end;

---

File: ServSalesTaxCalculate.Codeunit.al (codeunit 5968)