Change Internal Procedures in Create Inventory Put-away codeunit

[CnCollinsDC]

Why do you need this change?

We've made a change for our customer to allow them to create a put away from a Job Planning Line so that they can put back items which they do not need for the job anymore. We've managed to work around the issues we found but if you can remove the internal restriction from the following procedures, we'd be able to make it work using standard code rather than having to rewrite sections to do the same functionality.

We've also found a potential issue which we think affects your manufacturing extension in this same codeunit. The RemQtyToPutAway is a global variable that cannot be set from outside the codeunit while creating the lines. This means the call to the CreateWarehouseActivityLine procedure will not have this set. either this needs to be added as a parameter in the CreateWarehouseActivityLine and CreatePutawayWithPutawayTemplateBinPolicy or a procedure added to the codeunit to be able to set this variable before calling CreateWarehouseActivityLine and CreatePutawayWithPutawayTemplateBinPolicy .

Describe the request

Please can you change the following procedures:
OnCheckSourceDocForWhseRequest
FindNextLineNo
CreateWarehouseActivityLine
CreatePutawayWithPutawayTemplateBinPolicy

Internal work item: AB#615903

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Summary: Change access level from internal to public (no access modifier) for 3 procedures, and add a setter procedure for RemQtyToPutAway.

---

Implementation:

1. Change FindNextLineNo (line 1015):

    procedure FindNextLineNo()

2. Change CreateWarehouseActivityLine (line 637):

    procedure CreateWarehouseActivityLine(
        SourceType: Integer; DocumentType: Integer; DocumentNo: Code[20]; LineNo: Integer; SublineNo: Integer;
        LocationCode: Code[10]; ItemNo: Code[20]; VariantCode: Code[10]; UnitOfMeasureCode: Code[10]; QtyPerUnitMeasure: Decimal;
        QtyRndingPrecision: Decimal; QtyRndingPrecisionBase: Decimal; Description: Text[100]; Description2: Text[50]; DueDate: Date;
        BinCode: Code[20]; SourceRecordVariant: Variant): Decimal

3. Change CreatePutawayWithPutawayTemplateBinPolicy (line 780):

    procedure CreatePutawayWithPutawayTemplateBinPolicy(
        SourceType: Integer; DocumentType: Integer; DocumentNo: Code[20]; LineNo: Integer; SublineNo: Integer; LocationCode: Code[10]; BinCode: Code[20];
        ItemNo: Code[20]; VariantCode: Code[10]; QuantityBase: Decimal; UnitOfMeasureCode: Code[10]; QtyPerUnitMeasure: Decimal; QtyRndingPrecision: Decimal;
        QtyRndingPrecisionBase: Decimal; Description: Text[100]; Description2: Text[50]; DueDate: Date)

4. Add setter for RemQtyToPutAway variable:

    procedure SetRemQtyToPutAway(NewRemQtyToPutAway: Decimal)
    begin
        RemQtyToPutAway := NewRemQtyToPutAway;
    end;

---

File: CreateInventoryPutaway.Codeunit.al (codeunit 7321)