Skip to content

Conversation

@Cali0707
Copy link
Collaborator

This PR adds support for mcp server instructions

The current thinking is that they can be set in the config file, and when we see a need for providing any we can add our own default value in the code. For now I didn't have a good default value so I left it empty.

@nader-ziada
Copy link
Collaborator

so currently its empty and there is no way to set it?

@Cali0707
Copy link
Collaborator Author

so currently its empty and there is no way to set it?

yeah with the current code (not with this PR) you can't set it and it is empty.

What this does is adds support for setting it through the config file(s) - if we identify a good default for that we can also set a default value

@nader-ziada
Copy link
Collaborator

What this does is adds support for setting it through the config file(s) - if we identify a good default for that we can also set a default value

should we add this when we have a use for it then? or is there a need to add this support

@Cali0707
Copy link
Collaborator Author

should we add this when we have a use for it then? or is there a need to add this support

We have a need for this downstream in the openshift MCP server when running this in an ACM scenario with the ACM Search MCP server enabled as well - I just wasn't sure what value made sense here upstream

@nader-ziada
Copy link
Collaborator

/lgtm

@nader-ziada nader-ziada merged commit 70882a3 into containers:main Dec 11, 2025
17 of 21 checks passed
@manusa manusa added this to the 0.1.0 milestone Dec 12, 2025
@manusa
Copy link
Member

manusa commented Dec 12, 2025

This PR does enable the possibility to set it via config file (although it's undocumented, so it's a preview feature by all means).

At some point we might also want to add the option for toolsets to override/modify this (but we should really think about how to implement since there is the challenge when multiple toolsets converge).

/lgtm

I created a follow-up PR to simplify the test suite and also highlight how the instructions can be actually set (also makes it consistent with other tests such as the denied resources)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants