Enhance CommandMultipleCompletionsTestCase to include assertion for no completions yet

Author: andy1li

.github/workflows/publish.yml

@@ -17,13 +17,13 @@ jobs:
       - name: Unshallow
         run: git fetch --prune --unshallow
       - name: Set up Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v6
         with:
           go-version: 1.22.x
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v6
         with:
-          version: '~> v2'
+          version: "~> v2"
           args: release -f main.goreleaser.yml --clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test.yml

@@ -9,7 +9,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
       - name: Set up Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: 1.24.x
       - name: setup-env
@@ -28,7 +28,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Set up Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v6
         with:
           go-version: 1.24.x
 
@@ -113,7 +113,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Set up Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v6
         with:
           go-version: 1.24.x
 
@@ -124,4 +124,4 @@ jobs:
           uname -a
           compgen -ac | sort | grep '^ex'
 
-      - run: TEST_TARGET=test_bash RUNS=25 make test_flakiness
+      - run: TEST_TARGET=test_bash RUNS=25 make test_flakiness

internal/assertions/empty_line_assertion.go

@@ -0,0 +1,40 @@
+package assertions
+
+import (
+	"github.com/codecrafters-io/shell-tester/internal/screen_state"
+	"github.com/codecrafters-io/shell-tester/internal/utils"
+)
+
+// EmptyLineAssertion asserts that a single line of output is empty
+type EmptyLineAssertion struct {
+	// StayOnSameLine is a flag to indicate that the shell cursor
+	// should stay on the same line after the assertion is run
+	// Most probably because the next assertion will run on the same line
+	StayOnSameLine bool
+}
+
+func (a EmptyLineAssertion) Inspect() string {
+	return "EmptyLineAssertion"
+}
+
+func (a EmptyLineAssertion) Run(screenState screen_state.ScreenState, startRowIndex int) (processedRowCount int, err *AssertionError) {
+	processedRowCount = 1
+	if a.StayOnSameLine {
+		processedRowCount = 0
+	}
+
+	row := screenState.GetRow(startRowIndex)
+
+	if row.IsEmpty() {
+		return processedRowCount, nil
+	}
+
+	// Build error message
+	detailedErrorMessage := utils.BuildColoredErrorMessage("(empty line)", row.String(), "")
+	message := "Line is not empty.\n" + detailedErrorMessage
+
+	return 0, &AssertionError{
+		ErrorRowIndex: startRowIndex,
+		Message:       message,
+	}
+}

internal/stage7.go

@@ -68,11 +68,11 @@ func testType2(stageHarness *test_case_harness.TestCaseHarness) error {
 		var expectedPath = ""
 		if executable == "my_exe" {
 			expectedPath = filepath.Join(executableDir, myExeCommandName)
+		}
 
-			// Alpine Busybox has a bug where it doesn't check permissions
-			if isTestingTesterUsingBusyboxOnAlpine(stageHarness) {
-				expectedPath = nonExePath
-			}
+		// Alpine Busybox has a bug where it doesn't check permissions
+		if isTestingTesterUsingBusyboxAshOnAlpine(stageHarness) {
+			expectedPath = nonExePath
 		}
 
 		if err := testCase.RunForExecutable(asserter, shell, logger, expectedPath); err != nil {

internal/test_cases/command_multiple_completions_test_case.go

@@ -80,17 +80,24 @@ func (t CommandMultipleCompletionsTestCase) Run(asserter *logged_shell_asserter.
 	}
 
 	if t.CheckForBell {
+		// Assert no completions yet when the bell is received
+		asserter.AddAssertion(assertions.EmptyLineAssertion{
+			StayOnSameLine: true,
+		})
+
 		bellChannel := shell.VTBellChannel()
 		asserter.AddAssertion(assertions.BellAssertion{
 			BellChannel: bellChannel,
 		})
+
 		// Run the assertion, before sending the enter key
 		if err := asserter.AssertWithoutPrompt(); err != nil {
 			return err
 		}
-
 		logger.Successf("✓ Received bell")
-		// Pop the bell assertion after running
+
+		// Pop the bell assertion and empty line assertion after running
+		asserter.PopAssertion()
 		asserter.PopAssertion()
 	}
 

internal/utils_sys.go

@@ -8,14 +8,13 @@ import (
 )
 
 const ASH_PATH = "internal/test_helpers/ash/your_shell.sh"
-const DASH_PATH = "internal/test_helpers/dash/your_shell.sh"
 
-func isTestingTesterUsingBusyboxOnAlpine(stageHarness *test_case_harness.TestCaseHarness) bool {
+func isTestingTesterUsingBusyboxAshOnAlpine(stageHarness *test_case_harness.TestCaseHarness) bool {
 	path := stageHarness.Executable.Path
-	isTestingTesterUsingBusybox := strings.HasSuffix(path, ASH_PATH) || strings.HasSuffix(path, DASH_PATH)
+	isTestingTesterUsingBusyboxAsh := strings.HasSuffix(path, ASH_PATH)
 
 	_, err := os.Stat("/etc/alpine-release")
 	isOnAlpine := err == nil
 
-	return isTestingTesterUsingBusybox && isOnAlpine
+	return isTestingTesterUsingBusyboxAsh && isOnAlpine
 }